Skip to content

Revert "Bump orjson to 3.10.3 (#116945)"#118920

Merged
balloob merged 1 commit into
devfrom
revert_orjson2
Jun 6, 2024
Merged

Revert "Bump orjson to 3.10.3 (#116945)"#118920
balloob merged 1 commit into
devfrom
revert_orjson2

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jun 5, 2024

Proposed change

This reverts commit dc50095.

fixes #118507

While the original issue appears fixed, it seems a new problem was introduced in 3.10.1

issue https://github.com/ijl/orjson/issues/495

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco added this to the 2024.6.1 milestone Jun 5, 2024
@bdraco bdraco requested a review from a team as a code owner June 5, 2024 23:08
@home-assistant home-assistant Bot added cla-signed core dependency Pull requests marked as a dependency upgrade small-pr PRs with less than 30 lines. labels Jun 5, 2024
Copy link
Copy Markdown
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, that's unfortunate. PR looks good.

Maybe change the title to include the older version, so something like "Revert orjson to 3.9.15"?

@balloob balloob merged commit a095706 into dev Jun 6, 2024
@balloob balloob deleted the revert_orjson2 branch June 6, 2024 03:37
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed core dependency Pull requests marked as a dependency upgrade small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Current Docker RC tag won't boot on RaspberryPi 4 8Gb, Fatal Python error: Bus error

4 participants